[maintenance] diagnose long response latency #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1421 +/- ##
=========================================
Coverage ? 71.44%
=========================================
Files ? 240
Lines ? 9512
Branches ? 1044
=========================================
Hits ? 6796
Misses ? 2412
Partials ? 304
Continue to review full report at Codecov.
|
pcrespov
force-pushed
the
maintenance/diagnose-cancellations
branch
2 times, most recently
from
30f5e89 to
b76fb44
Compare
pcrespov
changed the title
added 19 commits
April 3, 2020 11:10
Removed monitoring_enabled option
ensures check does not raise exception when no middlewares in place added log failure as optional
_is_prod resolved at factory context
Reuses /v0/ as a simple check-run
No need for WEB_SERVER prefix since they do not collide
pcrespov
force-pushed
the
maintenance/diagnose-cancellations
branch
from
bdbeb84 to
96fdc6a
Compare
sanderegg
reviewed
Apr 3, 2020
odeimaiz
approved these changes
Apr 3, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Monitors webserver's traffic and diagnoses when the average latency of the last requests is over a given threshold. At that point, the diagnostics raises
HeathErrorwhich flags the service as unhealthy (i.e. healthy entrypoint returns 503). The swarm healthcheck mechanism can decide to restart it./v0/healthis new healthcheck entrypoint. The previous entrypoint,/v0/, is kept as a run check.New webserver module:
diagnostics: takes over the service monitoring, healthcheck & diagnostics entrypoints and its role is to monitor, diagnose and flag the state of the service.testing fixtures that emulate some of the situations found in actual deployed environs (see
services/web/server/tests/unit/test_healthcheck.py)Various small improvements in servicelib (i.e. Many TODO annotations not just deleted and actually implemented ;-) ) [see commits and file changes for details]
Some fixes in Makefile for recipes with target
Fixed issue with
os.makedirsfailure in development mode (@ignapas pls check in your OS)Related issue number
Supports #1426
How to test
cd services/web make devenv install-dev make tests-unitChecklist
make openapi-specs,git commit ...and thenmake version-*)